A number of methods in main/toolkit/source/layout/vcl/* use either
"!this" or "this" in a boolean context in order to detect being
called with a null object and exit early. In a valid C++ pr

A number of methods in main/toolkit/source/layout/vcl/* use either
"!this" or "this" in a boolean context in order to detect being
called with a null object and exit early. In a valid C++ program
"this" will never be null, so a compiler could legally optimize out
this comparision, which could potentially result in the method
dereferencing a null pointer later in the code. This situation
could only happen if the caller is using a null object pointer to
call the method or is using a object ref to call the method that
was generated by dereferencing a null pointer, neither of which is
valid. Resolve this by moving the checks out of the method and
into the caller.

Make this easier by changing the getImpl() method to return the
private *Impl pointer directly instead of deferencing the pointer
and returning a ref. The latter is invalid if the pointer is null.
This allows GetImpl() to be called in a boolean contect to peform
the check. It also allows a number of instances of "&getImpl()"
calls in a boolean context to be fixed by changing them to "getImpl()".
The address of a ref will never be zero in a valid C++ program, so
the compiler could potentially optimize out those checks.

There does not appear to be any need for Control and ComboBox to
use customized versions of GetImpl() since these appear to behave
identically to the versions generated by the canned macro, so switch
them back to the macro version.

This commit should result in no functional changes.

It seems like all of these checks for a null implementation should
not be necessary, but that requires further investigation.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1823225 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Translated German abbreviation (ggfs.) in comment

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1822714 13f79535-47bb-0310-9956-ffa450edef68

Be slightly less tricky and change
do {
} while (!this);
to
do {
} while (0);

Computing !this must be done at runtime, whereas the intent

Be slightly less tricky and change
do {
} while (!this);
to
do {
} while (0);

Computing !this must be done at runtime, whereas the intent is for
the loop to exit after the first iteration, which can be handled at
compile time when using a constant zero. Also, "this" should always
be non-NULL in valid c++ code, but if ever happened to be NULL, then
this code could loop forever.

While here, translate nearby comments.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1822695 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Deleted whitespace in update message

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1822069 13f79535-47bb-0310-9956-ffa450edef68

Update the Copyright year to 2012-2018 for packages

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821724 13f79535-47bb-0310-9956-ffa450edef68

Fixed wording

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821691 13f79535-47bb-0310-9956-ffa450edef68

Update the Copyright year to 2018

According to:
https://svn.apache.org/viewvc?view=revision&revision=1780015

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@182156

Update the Copyright year to 2018

According to:
https://svn.apache.org/viewvc?view=revision&revision=1780015

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821563 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fixed typos

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821338 13f79535-47bb-0310-9956-ffa450edef68

Fixed typos

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821337 13f79535-47bb-0310-9956-ffa450edef68

Fixed typos

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821336 13f79535-47bb-0310-9956-ffa450edef68

#i127662# send better window position to input method for suggestion window

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821262 13f79535-47bb-0310-9956-ffa450edef68

Revert the part of r1818099 that changed the hardwired awk command
in main/solenv/gbuild/Output.mk with $(gb_AWK). Unfortunately
$(gb_AWK) is not defined at this point, so this change caused

Revert the part of r1818099 that changed the hardwired awk command
in main/solenv/gbuild/Output.mk with $(gb_AWK). Unfortunately
$(gb_AWK) is not defined at this point, so this change caused
errors each time a gbuild makefile was invoked. The definition
of $(gb_AWK) is in the platform gbuild files, which are included
after Output.mk. Changing the order of the includes breaks the
Windows build due to other chicken vs. egg problems. Fortunately
using hardwired awk works everywhere except Solaris, which we no
longer support.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1820587 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Don't put "." in $PATH because it is somewhat inefficient
as well as hazardous, especially if a user does a manual build
and then continues to use the same shell session.

Fix on inst

Don't put "." in $PATH because it is somewhat inefficient
as well as hazardous, especially if a user does a manual build
and then continues to use the same shell session.

Fix on instance of a script in the current directory being
executed without a leading "./".

Remember to run "./bootstrap" as configure recommends. With
this change "bootstrap" without the leading "./" will no longer
work.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1820536 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Use $CC_PATH (with the trailing slash removed) instead of $COMPATH
when setting $PATH. The latter has the trailing /bin removed from
the path to the compiler executable and results in /usr b

Use $CC_PATH (with the trailing slash removed) instead of $COMPATH
when setting $PATH. The latter has the trailing /bin removed from
the path to the compiler executable and results in /usr being
incorrectly added to $PATH.

Remove an older, FreeBSD-specific workaround.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1820483 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Don't add X11 include directory to compiler command line if it is
/usr/include since the compiler will look there automatically.



git-svn-id: https://svn.apache.org/repos/asf/op

Don't add X11 include directory to compiler command line if it is
/usr/include since the compiler will look there automatically.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1820378 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Nothing uses GXX_INCLUDE_PATH, so remove it. The uretest/README
file mentions is being needed by the STLport included in the URE,
but that does not appear to be true any longer, and it is no

Nothing uses GXX_INCLUDE_PATH, so remove it. The uretest/README
file mentions is being needed by the STLport included in the URE,
but that does not appear to be true any longer, and it is not
used by boost.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1820351 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Some (minor) corrections to ReadMe

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1820131 13f79535-47bb-0310-9956-ffa450edef68

#i127158#

- AOO logo repositioned to align with the icons (suggested by mroe)
- Added ASF logo on the right side
- Moved all graphics up a bit
- Added a horizontal line to se

#i127158#

- AOO logo repositioned to align with the icons (suggested by mroe)
- Added ASF logo on the right side
- Moved all graphics up a bit
- Added a horizontal line to separate the logos from the icons

(Includes versions for "High Contrast", "Right to Left" and "Beta Builds")

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819607 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Updated to the latest version:
- config.guess: 2017-12-17
- config.sub: 2017-11-23

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819451 13f79535-47bb-0310-9956-ffa

Updated to the latest version:
- config.guess: 2017-12-17
- config.sub: 2017-11-23

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819451 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126518# OS/2 link with system libcx0 to use new exception and memory mapping handling.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819430 13f79535-47bb-0310-9956-ffa450e

#i126518# OS/2 link with system libcx0 to use new exception and memory mapping handling.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819430 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fixed translation like in Pootle (added leading space)

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819321 13f79535-47bb-0310-9956-ffa450edef68

#i127637# Sort components for languages that need multiple OXT files.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819301 13f79535-47bb-0310-9956-ffa450edef68

#i127637# Standardize on lowercase filenames for all bundled extensions.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819295 13f79535-47bb-0310-9956-ffa450edef68

#i127637# Use conventional filenames for locale-dependent dictionaries.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819294 13f79535-47bb-0310-9956-ffa450edef68

#i127637# Sort dictionaries by language code of the dictionary.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1819292 13f79535-47bb-0310-9956-ffa450edef68