Ps-3.14.4-with-nspr-4.9.5 has many security
vulnerabilities

Upgrade bundled nss-3.14.4-with-nspr-4.9.5 to nss-3.25-with-nspr-4.12.
These CVEs have been fixed since nss-3.14.4 was rel

Ps-3.14.4-with-nspr-4.9.5 has many security
vulnerabilities

Upgrade bundled nss-3.14.4-with-nspr-4.9.5 to nss-3.25-with-nspr-4.12.
These CVEs have been fixed since nss-3.14.4 was released:
CVE-2014-1533
CVE-2014-1534
CVE-2014-1536
CVE-2014-1537
CVE-2014-1540
CVE-2014-1541
CVE-2014-1542
CVE-2014-1543
CVE-2014-1544
CVE-2014-1545
CVE-2014-1547
CVE-2014-1548
CVE-2014-1549
CVE-2014-1550
CVE-2014-1551
CVE-2014-1552
CVE-2014-1555
CVE-2014-1556
CVE-2014-1557
CVE-2014-1558
CVE-2014-1559
CVE-2014-1560
CVE-2014-1561
CVE-2014-1568
CVE-2014-1569
CVE-2014-1587
CVE-2014-1588
CVE-2014-1589
CVE-2014-1590
CVE-2014-1591
CVE-2014-1592
CVE-2014-1593
CVE-2014-1594
CVE-2014-1595
CVE-2015-4513
CVE-2015-4514
CVE-2015-4515
CVE-2015-4518
CVE-2015-7181
CVE-2015-7182
CVE-2015-7183
CVE-2015-7185
CVE-2015-7186
CVE-2015-7187
CVE-2015-7188
CVE-2015-7189
CVE-2015-7190
CVE-2015-7191
CVE-2015-7192
CVE-2015-7193
CVE-2015-7194
CVE-2015-7195
CVE-2015-7196
CVE-2015-7197
CVE-2015-7198
CVE-2015-7199
CVE-2015-7200
CVE-2015-7575
CVE-2016-1938
CVE-2016-1950
CVE-2016-1978
CVE-2016-1979
Whether any of these actually impacts OpenOffice is not known.

Rebase the nss patches to the new version and move any non-conflicting
changes from the platform-specific patch files to nss.patch. The
nss.patch.mingw file was already out of date and was not updated.

Disable nss tests which require at least partial c++11 (-stdc++0x)
support because they use nullptr. This reportedly requires at least
gcc 4.6, which is newer that some of what is provided by some of
our supported platforms.

Fix build issue on FreeBSD 11.0 and other platforms with picky compilers.
The result of shifting a negative signed value is undefined in C and C++.
The generated code does the expected thing in my experience and this
construct just generates a compiler warning, but
nss-3.24/nss/lib/zlib/inflate.c is compiled with -Werror, which breaks
the build. Fix the issue by doing the calculations using the equivalent
unsigned type. The function return should probably also be changed, but
that is more invasive.

Patch pratom.h to no include <intrin.H> inside an extern "C" block
because it breaks the build on Windows.

Recent versions of nss include a new shared library, libfreeblpriv3.so,
so package it so that it gets installed.

Temporarily change nss download URL from https to http to avoid breaking
bootstrap on the buildbots.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1753148 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126892# The iweb sourceforge mirror appears to have been removed from
rotation, switch to the pilotfiber mirror.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk

#i126892# The iweb sourceforge mirror appears to have been removed from
rotation, switch to the pilotfiber mirror.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1752780 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Output Perl @INC, library locations, to help troubleshoot missing Perl modules.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1749607 13f79535-47bb-0310-9956-ffa450

Output Perl @INC, library locations, to help troubleshoot missing Perl modules.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1749607 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Add specification for needed Perl module LWP::Protocol.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1749400 13f79535-47bb-0310-9956-ffa450edef68

#i126999#: fix vcl/source/glyphs/graphite_layout.cxx compile with libc++ 3.8.0

Rename local inline function round() to round2long() to avoid ambiguity
with libc++ round() function and be

#i126999#: fix vcl/source/glyphs/graphite_layout.cxx compile with libc++ 3.8.0

Rename local inline function round() to round2long() to avoid ambiguity
with libc++ round() function and better describe its functionality. This
fixes a compile error when building with libc++ version 3.8.0, which
was first observed with FreeBSD 11.0.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1748663 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126893#: Upgrade bundled libxml2 version to 2.9.3 and libxslt to 1.1.28

These security vulnerabilities have been fixed since the release of
libxml2-2.7.8 which is bundled with OpenOffi

#i126893#: Upgrade bundled libxml2 version to 2.9.3 and libxslt to 1.1.28

These security vulnerabilities have been fixed since the release of
libxml2-2.7.8 which is bundled with OpenOffice:
CVE-2011-3202
CVE-2011-3919
CVE-2013-0338
CVE-2013-0339
CVE-2013-2877
CVE-2014-0191
CVE-2014-3660
CVE-2015-1819
CVE-2015-5312
CVE-2015-7497
CVE-2015-7498
CVE-2015-7499
CVE-2015-7500
CVE-2015-7941
CVE-2015-7942
CVE-2015-8035
CVE-2015-8241
CVE-2015-8242

This vulnerability has been fixed since the release of libxslt-1.1.26:
CVE-2015-7995

Upgrade libxml2 to version 2.9.3 which has no publicly disclosed
vulnerabilities at this time.

Rebase libxml2-configure.patch to the new version of libxml2. The
freebsd-elf change to ltmain.sh is no longer necessary and is eliminated
from the patch. The fixes in libxml2-fixes.patch were either fixed
upstream or don't seem to apply anymore, so this patch file was deleted.
The fixes in libxml2-testapi.patch and libxml2-runtest.patch are in now
in the upstream source, so these patch files have been deleted.
The libxml2-mingw.patch and Solaris-specific libxml2-global-symbols.patch
were not updated and are disconnected from the build. Several of the
fixes in libxml2-long-path.patch are now fixed upstream.

Upgrade libxslt to version 1.1.28 and add libxslt-CVE-2015-7995.patch,
which is imported from the FreeBSD port and which appears to have been
cherry picked from upstream.

Rebase libxslt-configure.patch to the new version of libxslt, with
the libtool-related changes coming from the libxslt port to FreeBSD.
The fixes in libxslt-bsd.patch are now present in the upstream
source, so this patch was deleted.

Tested by: kschenk


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1748497 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126916# windows build breaks in module formula

Don't use precompiled headers for forui, as it
sometimes breaks the Windows build.

Patch by: me



git-svn-id: h

#i126916# windows build breaks in module formula

Don't use precompiled headers for forui, as it
sometimes breaks the Windows build.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747968 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix a typo in my last patch.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747759 13f79535-47bb-0310-9956-ffa450edef68

#i126918# - windows build breaks in module crashrep - Assertion Failed

Prevent OSL assertion failures from bringing up messageboxes during
the build on Windows.

Patch by: me

#i126918# - windows build breaks in module crashrep - Assertion Failed

Prevent OSL assertion failures from bringing up messageboxes during
the build on Windows.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747758 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126917# windows build breaks in module connectivity/source/parse/sqliterator.cxx

Fix a *nix build breaker from my 2 previous commits.

Patch by: me



git-svn-id: h

#i126917# windows build breaks in module connectivity/source/parse/sqliterator.cxx

Fix a *nix build breaker from my 2 previous commits.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747442 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126917# windows build breaks in module connectivity/source/parse/sqliterator.cxx

Fix compile errors in Patricia's patch in #1747439.

Patch by: me



git-svn-id: ht

#i126917# windows build breaks in module connectivity/source/parse/sqliterator.cxx

Fix compile errors in Patricia's patch in #1747439.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747440 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126917# windows build breaks in module connectivity/source/parse/sqliterator.cxx

Commit Patricia's initial broken patch which starts in the right direction,
and fix it in my next commi

#i126917# windows build breaks in module connectivity/source/parse/sqliterator.cxx

Commit Patricia's initial broken patch which starts in the right direction,
and fix it in my next commit.

Patch by: pats
Review by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747439 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126888#: bundled boost headers generate an excessive number of
warnings when building with modern compilers

When building OpenOffice with modern compilers, the bundled boost
heade

#i126888#: bundled boost headers generate an excessive number of
warnings when building with modern compilers

When building OpenOffice with modern compilers, the bundled boost
headers generate an excessive number of warnings. This is especially
bad with recent versions of clang, which generates very verbose
warning messages.

The attached patch updates the current boost_1_55_0.patch with
additional changes cherry picked from upstream boost, up through
version 1.60. These additional changes have been used with the
FreeBSD boost 1.55.0 port for a while.

This patch greatly reduces the number of warnings and size of the
OpenOffice build log. Compiling trunk r1735889 on FreeBSD 11.0
with clang 3.8, the number of warnings is reduced from 53260 to
13741, and the size of the build log is reduced from 117 MB to 44
MB.

Tested by: kschenk


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747019 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Revert previous change, incorrect commit message



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747017 13f79535-47bb-0310-9956-ffa450edef68

#i124867#: bundled boost headers generate an excessive number of
warnings when building with modern compilers

When building OpenOffice with modern compilers, the bundled boost
heade

#i124867#: bundled boost headers generate an excessive number of
warnings when building with modern compilers

When building OpenOffice with modern compilers, the bundled boost
headers generate an excessive number of warnings. This is especially
bad with recent versions of clang, which generates very verbose
warning messages.

The attached patch updates the current boost_1_55_0.patch with
additional changes cherry picked from upstream boost, up through
version 1.60. These additional changes have been used with the
FreeBSD boost 1.55.0 port for a while.

This patch greatly reduces the number of warnings and size of the
OpenOffice build log. Compiling trunk r1735889 on FreeBSD 11.0
with clang 3.8, the number of warnings is reduced from 53260 to
13741, and the size of the build log is reduced from 117 MB to 44
MB.

Tested by: kschenk


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1747012 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i124867#: jpg options shows initially wrong estimated file size

File main/svtools/source/filter/exportdialog.cxx

ExportDialog::GetGraphicStream() creates the compressed file from w

#i124867#: jpg options shows initially wrong estimated file size

File main/svtools/source/filter/exportdialog.cxx

ExportDialog::GetGraphicStream() creates the compressed file from which the
file size is obtained, calling GetFilterData() to obtain the properties used
to save it. GetFilterData() returns image properties, like JPEG colormode
and quality, PNG compression/interlacing/translucence, BMP color and RLE
coding, etc. In the case of JPEG, the quality is read from
maSbCompression.GetThumbPos().

The problem is that in ExportDialog::updateControls(),
maSbCompression.SetThumbPos() is called AFTER GetGraphicStream(), meaning
the stream is created with the old thumb position.

This patches it to call GetGraphicStream() later, immediately before using
that stream, so that its properties such as compression are updated first
and the size is calculated correctly.

Reported by: myspaces at hotmail dot fr
Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1746906 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126736#: fix typo in systemactions.pm

Remove stray backslashes in warning messages in systemactions.pm which
cause warnings.

Patch by: j.nitschke@ok.de
Reviewed by: me

#i126736#: fix typo in systemactions.pm

Remove stray backslashes in warning messages in systemactions.pm which
cause warnings.

Patch by: j.nitschke@ok.de
Reviewed by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1746887 13f79535-47bb-0310-9956-ffa450edef68

show more ...

RAND(): Destroy the random pool after seeding.

We are using rtl_random() only for seeding, we can save some memory here.


git-svn-id: https://svn.apache.org/repos/asf/openoffice

RAND(): Destroy the random pool after seeding.

We are using rtl_random() only for seeding, we can save some memory here.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1746363 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Update APR and APR-util.

Update APR to version 1.5.2.
Update APR-util to version 1.5.4

This brings many updates and fixes that have little effect over Apache
OpenOffice at t

Update APR and APR-util.

Update APR to version 1.5.2.
Update APR-util to version 1.5.4

This brings many updates and fixes that have little effect over Apache
OpenOffice at this time.

Tested on FreeBSD.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745407 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix a string limit error in my previous patch.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1739631 13f79535-47bb-0310-9956-ffa450edef68

Make CSV line parsers consistent with CSV field parsers.

Our CSV field parsing algorithms treats fields starting with a quote
(immediately at the beginning of the row, or after the field

Make CSV line parsers consistent with CSV field parsers.

Our CSV field parsing algorithms treats fields starting with a quote
(immediately at the beginning of the row, or after the field delimiter) as
quoted. A quoted field ends at the corresponding closing quote, and any
remaining text between the closing quote and the next field delimeter or end
of line is appended to the text already extracted from the field, but not
processed further. Any quotes in this extra text are taken verbatim - they
do not quote anything.

Our CSV line parsers were big hacks - they essentially read and concatenate
lines until an even number of quote characters is found, and then feed this
through the CSV field parsers.

This patch rewrites the line parsers to work exactly how the field parsers
work. Text such as:
"another" ",something else
is now correctly parsed by both Calc and Base as:
[another "],[something else]
instead of breaking all further parsing.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1739628 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Replace 0 with NULL for pointers.

Only applied to C code: common syntax for C++ is different (nullptr).

Found with coccinelle: http://coccinelle.lip6.fr/


git-svn-id:

Replace 0 with NULL for pointers.

Only applied to C code: common syntax for C++ is different (nullptr).

Found with coccinelle: http://coccinelle.lip6.fr/


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1738404 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Drop redundant semicolons.

Found with coccinelle: http://coccinelle.lip6.fr/

Currently only applied to C code.


git-svn-id: https://svn.apache.org/repos/asf/openoffice

Drop redundant semicolons.

Found with coccinelle: http://coccinelle.lip6.fr/

Currently only applied to C code.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1738403 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126901# CSV import: values with + or - followed by thousand separator and
3 digits (eg. +,123) are imported as a number

Do not allow numbers parsed from CVS files when "Detect special

#i126901# CSV import: values with + or - followed by thousand separator and
3 digits (eg. +,123) are imported as a number

Do not allow numbers parsed from CVS files when "Detect special numbers" is
off, to contain thousand separators before digits, even if after a +/- sign
(eg. -,123 or +,789). Treat these as strings instead.

Also added unit tests for this and exported the ScStringUtil class so it
can be tested.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1737624 13f79535-47bb-0310-9956-ffa450edef68

show more ...