Fix improper usage of strncat() and snprintf(). Flagged by -Wstrncat-size
compiler warning from clang.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758884 13

Fix improper usage of strncat() and snprintf(). Flagged by -Wstrncat-size
compiler warning from clang.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758884 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Replace 0 with NULL for pointers.

Only applied to C code: common syntax for C++ is different (nullptr).

Found with coccinelle: http://coccinelle.lip6.fr/


git-svn-id:

Replace 0 with NULL for pointers.

Only applied to C code: common syntax for C++ is different (nullptr).

Found with coccinelle: http://coccinelle.lip6.fr/


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1738404 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Platforms that need CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT for sockets usually
need it for pipes too, and even if it isn't necessary it can't hurt.

In particular, on FreeBSD 11-CURRENT it see

Platforms that need CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT for sockets usually
need it for pipes too, and even if it isn't necessary it can't hurt.

In particular, on FreeBSD 11-CURRENT it seems pipes no longer wake up
from accept when closed in other threads, so let's deal with that before
FreeBSD 11 is released.

Reported by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e>
Patch by: me
Tested by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e>



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1728872 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Remember to NULL terminate when using strncpy.

All systems should have strlcpy.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1720862 13f79535-47bb-0310-9956-ff

Remember to NULL terminate when using strncpy.

All systems should have strlcpy.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1720862 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Use %tx to print ptrdiff_t.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719848 13f79535-47bb-0310-9956-ffa450edef68

Use %p to print pointers in sal backtraces instead of 0x%x + conversion to integer.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719846 13f7

Use %p to print pointers in sal backtraces instead of 0x%x + conversion to integer.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719846 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Drop useless malloc casts in C code

In ANSI C these casts are unnecessary and can hide warnings.
If this code is moved to C++ we may need such casts back
but we may then consider re-

Drop useless malloc casts in C code

In ANSI C these casts are unnecessary and can hide warnings.
If this code is moved to C++ we may need such casts back
but we may then consider re-writing the allocation code
altogether.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719566 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Missing Unlock

Condition broadcast failed but silently try to unlock the mutex.

CID: 705120

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717711 13f7953

Missing Unlock

Condition broadcast failed but silently try to unlock the mutex.

CID: 705120

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717711 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Off by one using readlink(2)

CID 705623, 982797

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717642 13f79535-47bb-0310-9956-ffa450edef68

Destination buffer too small

CID: 706154


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717148 13f79535-47bb-0310-9956-ffa450edef68

Use the ptrdiff_t printf format code for backtracing on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716788 13f79535-47bb-0310-9956

Use the ptrdiff_t printf format code for backtracing on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716788 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Implement osl_diagnose_backtrace_Impl() on FreeBSD. Also fix the value of FRAME_PTR_OFFSET
in both backtrace.c and diagnose.c - it's 3 because of the EBP/RBP register's position
in the jmp_bu

Implement osl_diagnose_backtrace_Impl() on FreeBSD. Also fix the value of FRAME_PTR_OFFSET
in both backtrace.c and diagnose.c - it's 3 because of the EBP/RBP register's position
in the jmp_buf (https://github.com/freebsd/freebsd/blob/master/lib/libc/amd64/gen/_setjmp.S
and https://github.com/freebsd/freebsd/blob/master/lib/libc/i386/gen/_setjmp.S).
This gets backtracing to fully work on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716759 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix the stack frame layout for backtraces on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716755 13f79535-47bb-0310-9956-ffa450edef

Fix the stack frame layout for backtraces on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716755 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i66807 - Fix GCC warning in backtrace.c

The Bugzilla issue has another fix for sparc but I have no way ot test it.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk

i66807 - Fix GCC warning in backtrace.c

The Bugzilla issue has another fix for sparc but I have no way ot test it.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716553 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Resource leak

CID: 1028069


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716163 13f79535-47bb-0310-9956-ffa450edef68

#i125194# Fix RC2 issue by changing approach.
Patch by: Giuseppe Castagno


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1709687 13f79535-47bb-0310-9956-ffa450edef68

#i126582# Prevent errors with read/only shares on Sharepoint.
Patch by: Giuseppe Castagno

Added a Windows API missing error:
ERROR_CANT_ACCESS_FILE
file cannot be accessed by the

#i126582# Prevent errors with read/only shares on Sharepoint.
Patch by: Giuseppe Castagno

Added a Windows API missing error:
ERROR_CANT_ACCESS_FILE
file cannot be accessed by the system.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1709212 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126586# don't break on non-Linux non-FreeBSD non-NetBSD *nix systems ...



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1708483 13f79535-47bb-0310-9956-ffa450edef68

#i126586# FreeBSD automation deadlock: osl_closeSocket() doesn't wake up thread stuck in accept().
Generalize the "#if defined(LINUX)" workarounds to the *BSDs.



git-svn-id: htt

#i126586# FreeBSD automation deadlock: osl_closeSocket() doesn't wake up thread stuck in accept().
Generalize the "#if defined(LINUX)" workarounds to the *BSDs.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1708477 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Bring back the casts for Win32.

Our old version of MSVC doesn't understand CERT secure C coding standard
MEM 02-A.

Reported by: damjan (through pescetti)


git-sv

Bring back the casts for Win32.

Our old version of MSVC doesn't understand CERT secure C coding standard
MEM 02-A.

Reported by: damjan (through pescetti)


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1707397 13f79535-47bb-0310-9956-ffa450edef68

show more ...

FreeBSD: Small cleanup and enhancement.

Reviewed by: Don Lewis


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1707381 13f79535-47bb-0310-9956-ffa450edef68

Enable some code from SUN Studio that works for other compilers (GCC).

Hinted from the OpenIndiana (Illumos) port by Alexander Pyhalov.



git-svn-id: https://svn.apache.org/

Enable some code from SUN Studio that works for other compilers (GCC).

Hinted from the OpenIndiana (Illumos) port by Alexander Pyhalov.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1707328 13f79535-47bb-0310-9956-ffa450edef68

show more ...

malloc + memset (0) --> calloc

Drop useless casts while here.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1706649 13f79535-47bb-0310-9956-ffa450edef68

#i125194# Fix WebDAV file locking.
Patch by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1705196 13f79535-47bb-0

#i125194# Fix WebDAV file locking.
Patch by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1705196 13f79535-47bb-0310-9956-ffa450edef68

show more ...