Re-enable some Id svn:keywords.

Most of these pre-existed in the code, probably due to older version
control. New Id keywords were added only in these files:

main/solenv/inc/mi

Re-enable some Id svn:keywords.

Most of these pre-existed in the code, probably due to older version
control. New Id keywords were added only in these files:

main/solenv/inc/minor.mk
main/vcl/unx/kde4/KDEXLib.cxx

The latter are important as they keep release information and we want
to maintain such references when new versions are bumped.
While here, update the information for KDE.




git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1775751 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Update endianness detection on FreeBSD.

This produces a working AOO on FreeBSD PowerPC64!

This is related to i126615 which was also fixed by Curtis a while ago.
Kudos for both c

Update endianness detection on FreeBSD.

This produces a working AOO on FreeBSD PowerPC64!

This is related to i126615 which was also fixed by Curtis a while ago.
Kudos for both contributions, makes me want to get a PowerPC to run
FreeBSD + AOO on it!

Author: Curtis Hamilton -- cmhamilto at gmail


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1773166 13f79535-47bb-0310-9956-ffa450edef68

show more ...

In the SAL_UNUSED macro, __attribute((__unused__)) should be
__attribute__((__unused__)), but both clang and gcc seem to understand
both.

Since __attribute__((__unused__)) can precee

In the SAL_UNUSED macro, __attribute((__unused__)) should be
__attribute__((__unused__)), but both clang and gcc seem to understand
both.

Since __attribute__((__unused__)) can preceed the variable name, just
like __pragma(warning(suppress:4100;suppress:4101)) for Visual Studio,
so de-parameterize the SAL_UNUSED macro.

Gcc whines if __attribute__((__unused__)) is used for a struct member,
so create a separate define, SAL_UNUSED_MEMBER, which is empty for
gcc, to handle struct members.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1759047 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix improper usage of strncat() and snprintf(). Flagged by -Wstrncat-size
compiler warning from clang.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758884 13

Fix improper usage of strncat() and snprintf(). Flagged by -Wstrncat-size
compiler warning from clang.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758884 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix -Wunused-private-field errors in sc/inc/compiler.hxx. The structure
ScDoubleRawToken contains four unused private fields. Mark these as
unused to eliminate the warning message. We can'

Fix -Wunused-private-field errors in sc/inc/compiler.hxx. The structure
ScDoubleRawToken contains four unused private fields. Mark these as
unused to eliminate the warning message. We can't delete these fields
because we want the layout of this structure to match ScRawToken.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758709 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Replace 0 with NULL for pointers.

Only applied to C code: common syntax for C++ is different (nullptr).

Found with coccinelle: http://coccinelle.lip6.fr/


git-svn-id:

Replace 0 with NULL for pointers.

Only applied to C code: common syntax for C++ is different (nullptr).

Found with coccinelle: http://coccinelle.lip6.fr/


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1738404 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Drop redundant semicolons.

Found with coccinelle: http://coccinelle.lip6.fr/

Currently only applied to C code.


git-svn-id: https://svn.apache.org/repos/asf/openoffice

Drop redundant semicolons.

Found with coccinelle: http://coccinelle.lip6.fr/

Currently only applied to C code.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1738403 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126890# code: compiling with recent clang generates thousands of infinite-recu
rsion warnings about DbgOut()

If the definition of the overloaded function DbgOut() in
sal/inc/rtl/st

#i126890# code: compiling with recent clang generates thousands of infinite-recu
rsion warnings about DbgOut()

If the definition of the overloaded function DbgOut() in
sal/inc/rtl/string.hxx is compiled without having first compiling
the the declaration of DbgOut() with a different signature in
tools/inc/tools/debug.hxx, the compiler thinks DbgOut() is calling
itself recursively with no means of escape.

Fix this in the case where DBG_UTIL is defined by including
<tools/debug.hxx> inside string.hxx so that the compiler will
encounter the declaration of DbgOut() in debug.hxx first in this
case. This requires adding a couple of directories to the compiler
include path so that the new consumers of <tools/debug.hxx> can
find it as well as one of its dependencies.

If DBG_UTIL is not defined, then debug.hxx does not declare DbgOut(),
so fix this case by hiding the DbgOut() definition in string.hxx
behind #ifdef DBG_UTIL since it won't be used in this case.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1736611 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Platforms that need CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT for sockets usually
need it for pipes too, and even if it isn't necessary it can't hurt.

In particular, on FreeBSD 11-CURRENT it see

Platforms that need CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT for sockets usually
need it for pipes too, and even if it isn't necessary it can't hurt.

In particular, on FreeBSD 11-CURRENT it seems pipes no longer wake up
from accept when closed in other threads, so let's deal with that before
FreeBSD 11 is released.

Reported by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e>
Patch by: me
Tested by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e>



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1728872 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Remove an unused empty file that is causing the RAT scan to fail.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1727463 13f79535-47bb-0310-995

Remove an unused empty file that is causing the RAT scan to fail.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1727463 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126787# fix unit tests on Windows

Fix a regression caused by r1710853 and which always existed in some files,
where <prewin.h> and <postwin.h> were being included before and after

#i126787# fix unit tests on Windows

Fix a regression caused by r1710853 and which always existed in some files,
where <prewin.h> and <postwin.h> were being included before and after
<windows.h>, yet unavailable as the tools module isn't built (and can't be)
before sal.

Patch by: j.nitschke at ok.de
Review by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1727413 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Remember to NULL terminate when using strncpy.

All systems should have strlcpy.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1720862 13f79535-47bb-0310-9956-ff

Remember to NULL terminate when using strncpy.

All systems should have strlcpy.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1720862 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Use %tx to print ptrdiff_t.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719848 13f79535-47bb-0310-9956-ffa450edef68

Use %p to print pointers in sal backtraces instead of 0x%x + conversion to integer.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719846 13f7

Use %p to print pointers in sal backtraces instead of 0x%x + conversion to integer.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719846 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Drop useless malloc casts in C code

In ANSI C these casts are unnecessary and can hide warnings.
If this code is moved to C++ we may need such casts back
but we may then consider re-

Drop useless malloc casts in C code

In ANSI C these casts are unnecessary and can hide warnings.
If this code is moved to C++ we may need such casts back
but we may then consider re-writing the allocation code
altogether.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1719566 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Missing Unlock

Condition broadcast failed but silently try to unlock the mutex.

CID: 705120

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717711 13f7953

Missing Unlock

Condition broadcast failed but silently try to unlock the mutex.

CID: 705120

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717711 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Off by one using readlink(2)

CID 705623, 982797

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717642 13f79535-47bb-0310-9956-ffa450edef68

Destination buffer too small

CID: 706154


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717148 13f79535-47bb-0310-9956-ffa450edef68

Use the ptrdiff_t printf format code for backtracing on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716788 13f79535-47bb-0310-9956

Use the ptrdiff_t printf format code for backtracing on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716788 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Implement osl_diagnose_backtrace_Impl() on FreeBSD. Also fix the value of FRAME_PTR_OFFSET
in both backtrace.c and diagnose.c - it's 3 because of the EBP/RBP register's position
in the jmp_bu

Implement osl_diagnose_backtrace_Impl() on FreeBSD. Also fix the value of FRAME_PTR_OFFSET
in both backtrace.c and diagnose.c - it's 3 because of the EBP/RBP register's position
in the jmp_buf (https://github.com/freebsd/freebsd/blob/master/lib/libc/amd64/gen/_setjmp.S
and https://github.com/freebsd/freebsd/blob/master/lib/libc/i386/gen/_setjmp.S).
This gets backtracing to fully work on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716759 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix the stack frame layout for backtraces on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716755 13f79535-47bb-0310-9956-ffa450edef

Fix the stack frame layout for backtraces on FreeBSD.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716755 13f79535-47bb-0310-9956-ffa450edef68

show more ...

i66807 - Fix GCC warning in backtrace.c

The Bugzilla issue has another fix for sparc but I have no way ot test it.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk

i66807 - Fix GCC warning in backtrace.c

The Bugzilla issue has another fix for sparc but I have no way ot test it.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716553 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Resource leak

CID: 1028069


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716163 13f79535-47bb-0310-9956-ffa450edef68

Fix a main/sal/qa/osl/mutex build error on MacOS.

Found by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Patch by: Pathangi Janardhanan Jatinshravan <JATIN

Fix a main/sal/qa/osl/mutex build error on MacOS.

Found by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Review by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1714423 13f79535-47bb-0310-9956-ffa450edef68

show more ...