Cleaned up resource file for page dialog.

Removed entries for MASKCOLOR.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1838006 13f79535-47bb-0310-9956-ffa450edef68

Cleaned up resource file for edit header/footer dialog.

Removed entries for MASKCOLOR.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1837835 13f79535-47bb-0310-9956-

Cleaned up resource file for edit header/footer dialog.

Removed entries for MASKCOLOR.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1837835 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Don't use !this as an alias for a constant that evaluates to false in
unconditional asserts. The former requires code to evaluate the
condition at runtime and also causes warnings from clang

Don't use !this as an alias for a constant that evaluates to false in
unconditional asserts. The former requires code to evaluate the
condition at runtime and also causes warnings from clang.

While here, translate the associated assert messages.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1830735 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fixed typos, removed whitespace

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1829759 13f79535-47bb-0310-9956-ffa450edef68

Fixed typos

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821336 13f79535-47bb-0310-9956-ffa450edef68

Enhance gb_LinkTarget_set_*_optimization functions to allow multiple
targets to be specified.

Convert optimization overrides in the gbuild library makefiles to
use gb_LinkTarget_set_

Enhance gb_LinkTarget_set_*_optimization functions to allow multiple
targets to be specified.

Convert optimization overrides in the gbuild library makefiles to
use gb_LinkTarget_set_*_optimization.

There should be no functional change.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1818290 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Make spreadsheets ask to update links. CVE CVE-2017-3157

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1813837 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1809373 13f79535-47bb-0310-9956-ffa450edef68

Fix a main/sc JunitTest typo.

Patch by: me


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1779290 13f79535-47bb-0310-9956-ffa450edef68

Build fixes for vbaobj on Windows.
Don't use SC_DLLIMPLEMENTATION, and link to sot.
With this, main/sc finally builds on Windows.

Patch by: me



git-svn-id: https://

Build fixes for vbaobj on Windows.
Don't use SC_DLLIMPLEMENTATION, and link to sot.
With this, main/sc finally builds on Windows.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1778965 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix symbol visibility problems with main/sc modules.

SC_DLLIMPLEMENTATION must only be defined for sc itself, not for scui or
scfilt, as that stops them from importing sc's symbols.

Fix symbol visibility problems with main/sc modules.

SC_DLLIMPLEMENTATION must only be defined for sc itself, not for scui or
scfilt, as that stops them from importing sc's symbols.

Should fix building main/sc on Windows.

Patch by: me


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1778961 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix some initial main/sc build issues on Windows caused by the
port to gbuild.

Note that it still doesn't build on Windows. Work is ongoing.

Patch by: me



git-

Fix some initial main/sc build issues on Windows caused by the
port to gbuild.

Note that it still doesn't build on Windows. Work is ongoing.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1778926 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Port main/sc to gbuild.
Also add the ability to add extra image directories to resources,
which is needed by main/sc.

Patch by: me


git-svn-id: https://svn.apache.org/re

Port main/sc to gbuild.
Also add the ability to add extra image directories to resources,
which is needed by main/sc.

Patch by: me


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1778876 13f79535-47bb-0310-9956-ffa450edef68

show more ...

In the SAL_UNUSED macro, __attribute((__unused__)) should be
__attribute__((__unused__)), but both clang and gcc seem to understand
both.

Since __attribute__((__unused__)) can precee

In the SAL_UNUSED macro, __attribute((__unused__)) should be
__attribute__((__unused__)), but both clang and gcc seem to understand
both.

Since __attribute__((__unused__)) can preceed the variable name, just
like __pragma(warning(suppress:4100;suppress:4101)) for Visual Studio,
so de-parameterize the SAL_UNUSED macro.

Gcc whines if __attribute__((__unused__)) is used for a struct member,
so create a separate define, SAL_UNUSED_MEMBER, which is empty for
gcc, to handle struct members.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1759047 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix by far the largest source of -Wtautological-undefined-compare
compile warnings.

The class definition for SdrMarkView in svx/inc/svx/svdmrkv.hxx
contains two inline methods that t

Fix by far the largest source of -Wtautological-undefined-compare
compile warnings.

The class definition for SdrMarkView in svx/inc/svx/svdmrkv.hxx
contains two inline methods that take a reference argument and
perform an &rArg == NULL test on it. The compiler warns that this
condition should always be false because dereferencing a NULL pointer
to generate a reference is not valid in C++ and a valid reference will
never be at address 0. Warnings are generated every time this header
is included in a .cxx file.

It turns out that there are no callers for the IsGluePoint() method,
so just comment out its definition.

It also turns out that all the callers of IsPointMarked() pass it
a dereferenced pointer, so convert IsPointMarked() to take a pointer
argument and modify all the callers to pass a pointer without
dereferencing it first.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758862 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix -Wunused-private-field errors in sc/inc/compiler.hxx. The structure
ScDoubleRawToken contains four unused private fields. Mark these as
unused to eliminate the warning message. We can'

Fix -Wunused-private-field errors in sc/inc/compiler.hxx. The structure
ScDoubleRawToken contains four unused private fields. Mark these as
unused to eliminate the warning message. We can't delete these fields
because we want the layout of this structure to match ScRawToken.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758709 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Merge branches/gbuild-reintegration to trunk.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1755455 13f79535-47bb-0310-9956-ffa450edef68

RAND(): Destroy the random pool after seeding.

We are using rtl_random() only for seeding, we can save some memory here.


git-svn-id: https://svn.apache.org/repos/asf/openoffice

RAND(): Destroy the random pool after seeding.

We are using rtl_random() only for seeding, we can save some memory here.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1746363 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535

Spelling, spelling ...

Why worry about some sprinkled German when we haven't yet learned English.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1745006 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126901# CSV import: values with + or - followed by thousand separator and
3 digits (eg. +,123) are imported as a number

Do not allow numbers parsed from CVS files when "Detect special

#i126901# CSV import: values with + or - followed by thousand separator and
3 digits (eg. +,123) are imported as a number

Do not allow numbers parsed from CVS files when "Detect special numbers" is
off, to contain thousand separators before digits, even if after a +/- sign
(eg. -,123 or +,789). Treat these as strings instead.

Also added unit tests for this and exported the ScStringUtil class so it
can be tested.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1737624 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i118023# Calc: Cut-and-paste between spreadsheets causes incorrect cell reference changes

When pasting cut cells, Calc updates references to their old positions
to instead refer to thei

#i118023# Calc: Cut-and-paste between spreadsheets causes incorrect cell reference changes

When pasting cut cells, Calc updates references to their old positions
to instead refer to their new positions. This is done using the tab index,
row and column, however the document is not taken into account. As a result,
when cutting and pasting between documents, cells in the target document
end up getting changed instead of in the source, potentially leading to
formula corruption, which is undoable but could easily go unnoticed,
causing data loss when the document is saved.

We don't really support inter-document reference updates anyway, so fix
this bug by restricting reference updates to the intra-document cut and
paste case only.

Patch by: me
Reviewed by: kschenk



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1730772 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126701# Patch for adding bit shift functions to calc

Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Review by: me




git-svn

#i126701# Patch for adding bit shift functions to calc

Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Review by: me




git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1718196 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126668# Addition of Bitwise Arithmetic Operations (BITAND, BITOR and BITXOR) in calc

Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Review by: me

#i126668# Addition of Bitwise Arithmetic Operations (BITAND, BITOR and BITXOR) in calc

Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Review by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1715605 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i35093# Find (and replace) on selected cells is misleading

When any cellc in Calc are selected at the time the "Find & Replace" dialog is opened,
automatically check the "Current select

#i35093# Find (and replace) on selected cells is misleading

When any cellc in Calc are selected at the time the "Find & Replace" dialog is opened,
automatically check the "Current selection only" checkbox, just like Writer does when
multiple lines of text are selected when this dialog opens. Users expect this from
Writer and other spreadsheets, and not doing it can even lead to wrong cells
being changed when "Replace" is used!

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1714091 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i60307# search for strings in date formats fails.
When "Search in" is set to "Values", search the formatted values
instead of just the raw input. This fixes a 9 year old
bug that's been

#i60307# search for strings in date formats fails.
When "Search in" is set to "Values", search the formatted values
instead of just the raw input. This fixes a 9 year old
bug that's been duplicated at least 6 times, and matches what Excel
does. Tests show even "Replace" works, and works well: if
"October" is replaced by "November", it converts the original
month from 10 to 11; it only converts the cell type to text if the
resulting text is no longer a valid date. Also added BVT tests
for the expected behaviour.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1712367 13f79535-47bb-0310-9956-ffa450edef68

show more ...