Revision tags: AOO420-Dev5-m5, AOO4115-GA, AOO4114-GA |
|
b9aa0698 | 12-Jan-2023 |
Damjan Jovanovic |
In ODF (19.679.2 of ODF 1.3), the <table:covered-table-cell> element's table:number-columns-repeated attribute has a default value of 1, meaning the cell spans the cell to its right. However
In ODF (19.679.2 of ODF 1.3), the <table:covered-table-cell> element's table:number-columns-repeated attribute has a default value of 1, meaning the cell spans the cell to its right. However when the XSLT import filter converts from SpreadsheetML's ss:MergeAcross to ODF's table:number-columns-repeated, it always inserts a <table:covered-table-cell> element, and then adds the table:number-columns-repeated attribute only if it is greater than 1. This breaks when ss:MergeAcross="0", because ODF's defaulting to 1 ends up occupying an extra empty cell to the right when it shouldn't. Fix this by only inserting the <table:covered-table-cell> when ss:MergeAcross > 0. Add a test document to prove this. Fixes #100989 - SpreadsheetML: cell with ss:MergeAcross="0" gets an extra empty cell to the right Patch by: me (cherry picked from commit a896732bfcd282115c06407a2f1da77694fa8d19)
show more ...
|
0f570a54 | 11-Jan-2023 |
Damjan Jovanovic |
Our XSLT-based MS Office 2003 SpreadsheetML format import filter, when doing conversion from R1C1 style column references to our A1 style references, had a bug where it was treating the colum
Our XSLT-based MS Office 2003 SpreadsheetML format import filter, when doing conversion from R1C1 style column references to our A1 style references, had a bug where it was treating the column value as 0-based, and dividing by 26 to find the 1st letter and taking the remainder when divided by 26 for the second letter. Those numbers are then each converted to a letter [0 = nothing, 1 = "A", 2 = "B", ..., 26 = "Z"]. However since R1C1 is 1-based, and not 0-based, this breaks for column numbers which are multiples of 26, as 26 mod 26 = 0, so the least significant digit is converted to nothing while the most significant digit gets incremented too early. Fix this by converting the column number to 0-based by subtracting 1 before calculation, then adding 1 to the least significant digit afterwards. Also the fact we have 2 letters limited us to a maximum of 26^2 = 676 columns, after which column references would wrap around. Fix this too, by adding a 3rd letter, which lets us address a maximum of 17576 columns. Add a sample file to our unit tests. Found by: alex dot plantema at xs4all dot nl Patch by: me (cherry picked from commit 577fe17932e0dec38662067d1a86e7fd6ae525b6)
show more ...
|
Revision tags: AOO420-Dev4-m4 |
|
a1409b3e | 24-Sep-2022 |
Carl Marcum |
Tab function test document and test (#156) Refs i19221 - added test and test document to test star basic Tab function in Calc. Patch-By: Czesław Wolański (cherry picked from com
Tab function test document and test (#156) Refs i19221 - added test and test document to test star basic Tab function in Calc. Patch-By: Czesław Wolański (cherry picked from commit 3b297b461537a449cdc46a885832873b48e62701)
show more ...
|
Revision tags: AOO4113-GA |
|
3b5ec47b | 10-Jun-2022 |
Carl Marcum |
Refs i126272 - add test and test document for testing Basic comment in single-line if statements (#152) * Refs i126272 - added test and test document to test fix for comment in single line i
Refs i126272 - add test and test document for testing Basic comment in single-line if statements (#152) * Refs i126272 - added test and test document to test fix for comment in single line if statement. (cherry picked from commit 07758af81c4094b8c020cf9852c971f9ff19be4f)
show more ...
|
48b860b6 | 14-Jan-2023 |
Damjan Jovanovic |
When importing SpreadsheetML ss:DateTime, import the entire value, not only the first 19 characters. Add a test file for this bug. Fixes: #128554 - Office 2003 SpreadsheetML: fr
When importing SpreadsheetML ss:DateTime, import the entire value, not only the first 19 characters. Add a test file for this bug. Fixes: #128554 - Office 2003 SpreadsheetML: fractional seconds are silently ignored during import Patch by: me (cherry picked from commit 195282cf3d8bfaa9e1cec43b093251d9df87f4ba)
show more ...
|
Revision tags: AOO4112-GA, AOO4111-GA, AOO420-Dev3-m3, AOO4110-GA, AOO419-GA, AOO418-GA, 420-Dev2-m2, AOO417, AOO420-Dev-m1, AOO416, AOO416-RC1, AOO415, AOO414, AOO413, AOO4121 |
|
725d8673 | 24-Nov-2015 |
Damjan Jovanovic |
#i117960# Basic: Line Input doesn't work in single-line If i92642 added the ability to use certain keywords as variable names (eg. name = 1, line = "hi"), but also caused a regression wh
#i117960# Basic: Line Input doesn't work in single-line If i92642 added the ability to use certain keywords as variable names (eg. name = 1, line = "hi"), but also caused a regression where "Line Input" is broken in single-line If statements. This patch fixes that by allowing Then and Else to also be the start-of-line tokens expected to immediately preceed the "Line" token in order for that "Line" token to be recognized a keyword instead of a variable name. Also added FVT spreadsheet tests for "Line" as both a variable name and as "Line Input". Patch by: me git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1716234 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|
Revision tags: AOO412, SNAPSHOT, AOO411 |
|
3de57b87 | 09-Sep-2015 |
Damjan Jovanovic |
#i123901# formula DGET() gives #VALUE! error when fetching calculation resulting in string Gets ScDBQueryDataIterator::DataAccessInternal::getCurrent() to handle formulas returning strings. A
#i123901# formula DGET() gives #VALUE! error when fetching calculation resulting in string Gets ScDBQueryDataIterator::DataAccessInternal::getCurrent() to handle formulas returning strings. Added a spreadsheet test for this behaviour. git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1702107 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|
323c3501 | 26-Aug-2015 |
Damjan Jovanovic |
#i112383# CLng("&HFFFFFFFF") fails on 64-bits rather than returning -1 Found-by: andrew Patch-by: Damjan Jovanovic git-svn-id: https://svn.apache.org/repos/asf/openoff
#i112383# CLng("&HFFFFFFFF") fails on 64-bits rather than returning -1 Found-by: andrew Patch-by: Damjan Jovanovic git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1697984 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|
c7723a22 | 26-Aug-2015 |
Damjan Jovanovic |
#i117989# Basic functions Day(), Hour(), Minute(), and Second() return wrong results for dates <1900-1-1 Also extended our spreadsheeet test to search through more columns, open spreadsheets
#i117989# Basic functions Day(), Hour(), Minute(), and Second() return wrong results for dates <1900-1-1 Also extended our spreadsheeet test to search through more columns, open spreadsheets with macros enabled, and added a test for the the Year(), Month(), Day(), Hour(), Minute(), and Second() functions comparing Calc's formulas vs StarBasic's runtime functions. Found-by: villeroy Patch-by: Damjan Jovanovic git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1697807 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|
Revision tags: AOO410, AOO410_Beta, AOO401 |
|
11e9ca94 | 27-Aug-2013 |
Herbert Dürr |
#i123119# add test script for checking manual-test friendly spreedsheets The script looks for the columns with "TestID" and "TestOK" markers. All cells below "TestID" are assumed to be t
#i123119# add test script for checking manual-test friendly spreedsheets The script looks for the columns with "TestID" and "TestOK" markers. All cells below "TestID" are assumed to be test names, all values below "TestOK" are assumed to be test results. If any of the test results evaluates to "FALSE" or zero the automatic test is marked as failed. git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1517802 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|
Revision tags: AOO400, AOO340 |
|
3ecf08d2 | 25-Oct-2012 |
Li Feng Wang |
fix problems in test scripts git-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1402019 13f79535-47bb-0310-9956-ffa450edef68 |
43a102b2 | 24-Oct-2012 |
Li Feng Wang |
#120968 - [testuno]Check graphic position and size properties patch by louql, reviewed by WangLiFeng git-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1401603 13f79535-47
#120968 - [testuno]Check graphic position and size properties patch by louql, reviewed by WangLiFeng git-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1401603 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|
07edb14c | 12-Sep-2012 |
Liu Zhe |
#120817 - [testuno] Delete contents in Spreadsheet. Patch By: Guo Bin <binbjguo@gmail.com> Review By: Liu Zhe <aliuzhe@gmail.com> git-svn-id: https://svn.apache.org/repos/asf/incubat
#120817 - [testuno] Delete contents in Spreadsheet. Patch By: Guo Bin <binbjguo@gmail.com> Review By: Liu Zhe <aliuzhe@gmail.com> git-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1383816 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|
6b55ece7 | 03-Sep-2012 |
Liu Zhe |
Move all data files from source to data dir. Make eclipse to avoid copy these files during compiling. git-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1380112 13f79535-47bb-0
Move all data files from source to data dir. Make eclipse to avoid copy these files during compiling. git-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1380112 13f79535-47bb-0310-9956-ffa450edef68
show more ...
|