nActiveCharPos can be less than mnMinCharPos if the ScriptItemize() call
in UniscribeLayout::LayoutText() finds a mult-character script item
that starts in the leading context and overlaps in

nActiveCharPos can be less than mnMinCharPos if the ScriptItemize() call
in UniscribeLayout::LayoutText() finds a mult-character script item
that starts in the leading context and overlaps into the start of the
run. UniscribeLayout::LayoutText() drops the glyphs for the context
characters, but does not (yet?) adjust the starting character position
of the item. Since the text layout direction can't change in the
middle of the offending script item, we can safely use the direction at
the start of the run.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1837765 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Minor cleanup

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1835669 13f79535-47bb-0310-9956-ffa450edef68

Cleaned up print dialog

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1835558 13f79535-47bb-0310-9956-ffa450edef68

Fixed typos:
sensisitive -> sensitive

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1832730 13f79535-47bb-0310-9956-ffa450edef68

The register storage class is deprecated and is incompatible with C++17.
Modern compilers have mostly been ignoring it, probably other than to
forbid the use of the address-of operator. Get

The register storage class is deprecated and is incompatible with C++17.
Modern compilers have mostly been ignoring it, probably other than to
forbid the use of the address-of operator. Get ahead of the game and
delete it now.

Reported by clang 6.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1830707 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i127729# Add full drag&drop support for the OS/2 platform.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1827936 13f79535-47bb-0310-9956-ffa450edef68

#i127662# send better window position to input method for suggestion window

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1821262 13f79535-47bb-0310-9956-ffa450edef68

Add range checking to PNG palette indexes,
as per OSS-Fuzz issue 574.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1816295 13f79535-47bb-

Add range checking to PNG palette indexes,
as per OSS-Fuzz issue 574.

Patch by: me



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1816295 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fixed typos (documention->documentation)

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1784437 13f79535-47bb-0310-9956-ffa450edef68

CFF: raise FDArray count limit to 256.

Per spec, the maximum for FDArray elements is 256, something that is not
common but some people like to test the limits [1].

Thanks to Aud

CFF: raise FDArray count limit to 256.

Per spec, the maximum for FDArray elements is 256, something that is not
common but some people like to test the limits [1].

Thanks to Audrey Tang for posting a patch under CC0 Universal declaration
which I found by accident.

[1] http://blogs.adobe.com/CCJKType/2012/05/all-unicode-cfr.html


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1765111 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Adapt TrueType font detection for the Apple specification variant.

From the Microsoft OpenType Specification:
https://www.microsoft.com/typography/otspec/otff.htm

NOTE: The Appl

Adapt TrueType font detection for the Apple specification variant.

From the Microsoft OpenType Specification:
https://www.microsoft.com/typography/otspec/otff.htm

NOTE: The Apple specification for TrueType fonts allows for 'true' and
'typ1' for sfnt version. These version tags should not be used for fonts
which contain OpenType tables.
____

We are complying with the OpenType usage fine but we were not taking into
account the NOTE so Apple TrueType variants would not be recognized.

Apparently valid values are 0x00010000 and 0x00020000. Keep it simple and
just assume any value different than zero is valid here.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1765086 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix -Wshift-negative-value compiler warnings. The result of shifting
negative integer values is undefined, so change the operand to be
unsigned.



git-svn-id: https://svn.ap

Fix -Wshift-negative-value compiler warnings. The result of shifting
negative integer values is undefined, so change the operand to be
unsigned.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758692 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix -Wformat-security warnings.

There are a number of instances where the code calls *printf() to
print arbitrary strings and the string is passed as the format
argument to *printf()

Fix -Wformat-security warnings.

There are a number of instances where the code calls *printf() to
print arbitrary strings and the string is passed as the format
argument to *printf(). Since these strings might contain %
conversion sequences, this is a security hazard. Fix the problem
by printing the strings with a "%s" format.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758644 13f79535-47bb-0310-9956-ffa450edef68

show more ...

Fix -Wformat-security warnings.

CreateT3FromTTGlyphs() uses a bunch of "const char *" variables to hold
the format strings for its fprintf() calls resulting in warnings that
the form

Fix -Wformat-security warnings.

CreateT3FromTTGlyphs() uses a bunch of "const char *" variables to hold
the format strings for its fprintf() calls resulting in warnings that
the format strings for these calls are not string literals. Suppress
these warnings by changing the variables to be "const char * const".



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1758639 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126999#: fix vcl/source/glyphs/graphite_layout.cxx compile with libc++ 3.8.0

Rename local inline function round() to round2long() to avoid ambiguity
with libc++ round() function and be

#i126999#: fix vcl/source/glyphs/graphite_layout.cxx compile with libc++ 3.8.0

Rename local inline function round() to round2long() to avoid ambiguity
with libc++ round() function and better describe its functionality. This
fixes a compile error when building with libc++ version 3.8.0, which
was first observed with FreeBSD 11.0.



git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1748663 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i126753# fix invalid parse of GSUB table for OpenType fonts

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1721674 13f79535-47bb-0310-9956-ffa450edef68

Prevent division by zero

CID: 735658, 735659


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717552 13f79535-47bb-0310-9956-ffa450edef68

Fix mismatch in r1717119

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717188 13f79535-47bb-0310-9956-ffa450edef68

Resource Leak

CID: 705772


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1717119 13f79535-47bb-0310-9956-ffa450edef68

#i126560# Fix print job counter reset.
Patch by: Damjan Jovanovic <damjan@apache.org>


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1705193 13f79535-47bb-0310-9956-f

#i126560# Fix print job counter reset.
Patch by: Damjan Jovanovic <damjan@apache.org>


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1705193 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i63015# always default to WinAnsiEncoding for non-symbol PDF-Type1 export

Suggested-By: edv@gruene.de
Reviewed-By: hdu@apache.org


git-svn-id: https://svn.apache.org/repos/

#i63015# always default to WinAnsiEncoding for non-symbol PDF-Type1 export

Suggested-By: edv@gruene.de
Reviewed-By: hdu@apache.org


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1631975 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#121627# merge fix from aoo410 branch that fixes the geometry calculations for scroll bars

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1604149 13f79535-47bb-0310-9956-ffa45

#121627# merge fix from aoo410 branch that fixes the geometry calculations for scroll bars

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1604149 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i124915# use target device dependent font height again

Setting a fixed default font height parameter doesn't make much sense when
neither the target device nor its mapping mode nor its

#i124915# use target device dependent font height again

Setting a fixed default font height parameter doesn't make much sense when
neither the target device nor its mapping mode nor its target resolution are
known. This change reverts revision 1589449 of bug 124686 that has already been
solved differently and restores the previous behaviour so that the default height
of default constructed fonts is set to 12pt when the target device becomes known.

Reviewed-by: Armin Le Grand <alg@apache.org>


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1596566 13f79535-47bb-0310-9956-ffa450edef68

show more ...

#i124922# allow late setting of the font color for CoreText-layouted text


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1595858 13f79535-47bb-0310-9956-ffa450edef68

Many spelling fixes: directories r* - z*.

Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame

Many spelling fixes: directories r* - z*.

Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1591062 13f79535-47bb-0310-9956-ffa450edef68

show more ...