f13410cf | 22-Jul-2024 |
Damjan Jovanovic |
Allow reading lines longer than 64 KiB in SvStream, and reading CSV rows and cells longer than 64 KiB in OpenOffice Base. (They are now limited to ~2 GiB). - New member functions wer
Allow reading lines longer than 64 KiB in SvStream, and reading CSV rows and cells longer than 64 KiB in OpenOffice Base. (They are now limited to ~2 GiB). - New member functions were added to the main/tools SvStream class to work with 32 bit ::rtl::OUString and ::rtl::OStringBuilder when reading lines. - The helper class QuotedString had to be upgraded from using the 16 bit String to the 32 bit ::rtl::OUString. - The CSV database driver was patched to use ::rtl::OUString and 32 bit indexes in various places. - Luckily, little other work was needed, as the ORowSetValue class already uses 32 bit ::rtl::OUString, and was previously converting 16 bit String to 32 bit ::rtl::OUString internally anyway. Also simplified some of the line parsing logic, and translated some German comments to English. Patch by: me (cherry picked from commit 7b2bc0e6bba2fbc38d078306fe10d875115d6c86)
show more ...
|
6c882b5c | 03-Apr-2016 |
damjan |
#i122754# Base does not properly parse CSV files as per RFC-4180 (while Calc does) The flat file driver, in file main/connectivity/source/drivers/flat/ETable.cxx, method OFlatTab
#i122754# Base does not properly parse CSV files as per RFC-4180 (while Calc does) The flat file driver, in file main/connectivity/source/drivers/flat/ETable.cxx, method OFlatTable::fillColumns(), which reads lines to initialize columns, assumes fields in the header and the first few lines never continue onto the next line(s). This causes truncation of columns when they do. Read all lines using the readLine() method instead of SvStream::ReadByteStringLine(), which takes overflow onto next lines into account. Also implement a new version of readLine() which allows reading into an arbitrary string, as opposed to m_aCurrentLine only. Patch by: me git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1737591 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 6b41ff7abde450fb0368489eb47c02e30b544097)
show more ...
|